[Issue-3658] Allow customizing fee for substrate/evm transactions #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issue-3745] - Update message in case perform Liquid staking have XCM
dungnguyen-art
force-pushed
the
koni/dev/issue-3658
branch
from
8a4c4c7 to
fb04a8b
Compare
dungnguyen-art
force-pushed
the
koni/dev/issue-3658
branch
from
0172bb8 to
fccd2b1
Compare
S2kael
requested changes
Jan 17, 2025
|
|
||
| const freeBalanceSubject = new Subject<AmountData>(); | ||
| const feeSubject = new Subject<FeeInfo>(); | ||
| const feeChainType: FeeChainType = isXcmTransfer |
S2kael
requested changes
Jan 20, 2025
| ? 'evm' | ||
| : 'substrate'; | ||
|
|
||
| const convertData = async (freeBalance: AmountData, fee: FeeInfo): Promise<ResponseSubscribeTransfer> => { |
| let maxTransferable = new BigN(freeBalance.value); | ||
|
|
||
| try { | ||
| if (isXcmTransfer) { |
There was a problem hiding this comment.
Split into multi function to clear logic
S2kael
reviewed
Jan 20, 2025
| @@ -3859,10 +4137,17 @@ export default class KoniExtension { | |||
| const evmApi = this.#koniState.getEvmApi(chain); | |||
| const metadata = notification.metadata as ClaimPolygonBridgeNotificationMetadata; | |||
|
|
|||
| const getChainFee: GetFeeFunction = (id, chain, type) => { | |||
dungnguyen-art
force-pushed
the
koni/dev/issue-3658
branch
from
426ecb4 to
fe58b5a
Compare
saltict
force-pushed
the
subwallet-dev
branch
from
04f64bc to
a4680ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3658